Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Should support requestFullscreen() #27

Open
jsantell opened this issue Sep 28, 2017 · 4 comments
Open

Should support requestFullscreen() #27

jsantell opened this issue Sep 28, 2017 · 4 comments

Comments

@jsantell
Copy link
Contributor

via google-ar/three.ar.js#24

@machenmusik
Copy link
Contributor

Is the request for fullscreen camera view to avoid minor misalignment like #25, or to hide the browser chrome when fullscreen is requested (which #25 doesn't do), or both?

@joseeph
Copy link

joseeph commented Oct 25, 2017

@machenmusik I think I needed mainly for hiding the url bar to enable full screen experience. were there any solutions already? Many thanks. :p

@machenmusik
Copy link
Contributor

Well, I had submitted a PR #25 that makes the webview full screen, but I am not sure @jsantell @judax et al. are planning to merge. Note that the PR does not wire up hiding the URL bar, which sounds like what you wanted to do

@judax judax mentioned this issue Nov 14, 2017
@machenmusik
Copy link
Contributor

Right, so I think that #25 was a sub-optimal but convenient approach, but I think the first question is whether the minor misalignment (because the coordinate translation was not taking into account the controls chrome) is still happening

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants