Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for testing KindUnexpected case in Mongo query function #1883

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

yatesliang
Copy link
Contributor

What is the problem I am trying to address?

Provided unit test for testing the error paths for Mongo query function, which will return the error type KindUnexpected

How is the fix applied?

  1. Insert error documents into the module collection
  2. Getter will fail to decode the error fields (in type integer or boolean) to []byte
  3. Error KindUnexpected return

What GitHub issue(s) does this PR fix or close?

Fixes #1327

@yatesliang yatesliang requested a review from a team as a code owner September 8, 2023 07:02
@manugupt1
Copy link
Member

Thank you!

@manugupt1 manugupt1 merged commit aca3cc0 into gomods:main Sep 25, 2023
8 checks passed
kmuchmore pushed a commit to kmuchmore/athens that referenced this pull request Oct 26, 2023
@DrPsychick DrPsychick added this to the 0.13.0 milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for error paths in Mongo query funtion
3 participants