Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logrus with log/slog #1890

Open
uhthomas opened this issue Sep 14, 2023 · 5 comments
Open

Replace logrus with log/slog #1890

uhthomas opened this issue Sep 14, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on!
Milestone

Comments

@uhthomas
Copy link
Contributor

Given the release of log/slog, it would be nice to replace logrus with it. There isn't really a great standard for logging in this repository, so this could also be considered a feature request for better logging in general.

I found it hard to add new log lines when working on #1887.

@matt0x6F
Copy link
Contributor

I'm okay with this change, I think it would be a step in the right direction since Logrus is in maintenance mode. There's some specialized field renaming that happens with CloudRuntime that we'd need to accommodate but I think everything else is pretty straight forward.

@matt0x6F matt0x6F added enhancement New feature or request good first issue Great issues for new Athenians to work on! labels Mar 26, 2024
@matt0x6F matt0x6F added this to the 0.14.0 milestone Mar 28, 2024
@matt0x6F matt0x6F modified the milestones: 0.14.0, 0.15.0 Apr 20, 2024
@Vector-ops
Copy link

I want to work on this

@matt0x6F
Copy link
Contributor

matt0x6F commented Sep 9, 2024

@Vector-ops go for it

@leonhfr
Copy link

leonhfr commented Oct 3, 2024

Are you working on this @Vector-ops? Otherwise I'd like to give it a shot

@Vector-ops
Copy link

Are you working on this @Vector-ops? Otherwise I'd like to give it a shot

I was working on it but I have my hands full right now. You can have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on!
Projects
None yet
Development

No branches or pull requests

4 participants