Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake support in Reladomo #264

Open
IcebearTopGun opened this issue Jan 5, 2024 · 5 comments
Open

Snowflake support in Reladomo #264

IcebearTopGun opened this issue Jan 5, 2024 · 5 comments

Comments

@IcebearTopGun
Copy link

Currently Reladomo does not support Snowflake Database type.
IN case we want to add this support what would be a good point to start with.
As per my understanding we need to touch DatabaseType and Connection Manager in Reladomo for the same rest should be as it is.

Want to understand how much of a dev effort it will be to make Snowflake support in it.

@mohrezaei
Copy link
Collaborator

I had a quick look at their docs. They have a JDBC driver which is great. What you'll need:

  1. a test environment
  2. create a new DatabaseType
  3. test some general stuff. Simple finds, finds with relationships, transactions, etc.
  4. write some tests that work out the behavior of various thing, e.g. batch statements in this particular DB.

For 3 and 4, you can reuse some of the code from other DB specific tests.

Generally, this sort of thing takes days, not weeks/months.

@IcebearTopGun
Copy link
Author

IcebearTopGun commented Jan 9, 2024

After running the build.md the project is still missing dependency and not auto detecting the dependencies.

<version>@mithra.version@</version>

This @ notation is causing breaks , Also what is the use of this https://github.com/goldmansachs/reladomo/blob/master/libboot/src/main/java/org/libboot/Libboot.java

Is it also a pre-requisite for project setup ? Do we have to trigger this or build.bat auto runs it ?

As per readme build.bat is only this required to setup the project

@mohrezaei
Copy link
Collaborator

the pom templates are for maven uploads, not building the project.

Please read the build instructions:
https://github.com/goldmansachs/reladomo/blob/master/BUILD.md

@IcebearTopGun
Copy link
Author

this runs fine for me gives success status, but when resolving classes code breaks.
saying @mithra.version is not found

@mohrezaei
Copy link
Collaborator

what is resolving classes? the build is command line only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants