Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load extension styles with relevant core blocks #2591

Merged

Conversation

AnthonyLedesma
Copy link
Member

Description

Load extension styles for specific core block styles.
This moves the styles out of global style-coblocks-1.css file into style-coblocks-extensions.
It also ensures that expected extension styles are loaded for the respective core blocks.
New tests to validate proper enqueue for expected blocks.

Screenshots

Before
Screenshot 2024-02-28 at 8 22 06 AM

After
Screenshot 2024-02-28 at 9 03 13 AM

Types of changes

Php changes to enqueue logic, relocation of styles, and some extension files for consistency.

How has this been tested?

Tested manually, tested with Unit Tests.

Acceptance criteria

Must enqueue block style css when only the core block is used.
core/image
core/button
core/list
core/media-text
core/cover

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma self-assigned this Feb 28, 2024
@EvanHerman EvanHerman self-requested a review February 28, 2024 17:56
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working well on my end 👍

@AnthonyLedesma AnthonyLedesma merged commit 32025bc into master Feb 28, 2024
48 checks passed
@AnthonyLedesma AnthonyLedesma deleted the load-extension-styles-with-relevant-core-blocks branch February 28, 2024 18:32
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants