Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support #13

Open
glut23 opened this issue Jun 21, 2017 · 4 comments
Open

Proxy support #13

glut23 opened this issue Jun 21, 2017 · 4 comments

Comments

@glut23
Copy link

glut23 commented Jun 21, 2017

In our integration with GoCardless we need to be able to use a proxy to communicate with the API. Currently there is no option available in the library to do so. As the library uses requests it would be great if we could specify the proxies parameter that this function accepts. Would it be possible to add support for using a proxy?

@timrogers
Copy link

@glut23 Thanks for your issue! Your request makes total sense to me - we'll have a bit more of a think about this, and aim to get back to you within the next week or so.

@timrogers
Copy link

I'd love to know what the use case is for using a proxy to interact with the GoCardless API too - would you give me a bit more information?

@glut23
Copy link
Author

glut23 commented Jun 21, 2017

@timrogers sure, any request coming from our apps that needs to go to the internet go out via a proxy (squid proxy server in our case). We implemented a temporal solution to make it work monkey patching your ApiClient for one that adds the proxies in the requests. Of course doing this is not ideal and it would be great to have this feature supported by the library. Thanks in advance.

@timrogers
Copy link

@glut23 Thanks! We'll have a think about this - it's something we'd like to do, but it might take us a little while to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants