-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate manual tests #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic testing wasn't possible in #785 (comment), but is now with cram.
sim642
commented
Oct 7, 2022
What are our plans vis-à-vis this PR? If we want to have it, I'll be happy to review once it's brought up-to-date with master. Otherwise, I suggest we close it. |
This was referenced Feb 8, 2024
To merge this PR, it would be good to add a white list of tests that already exist. |
diff binary gives differently biased output on OSX, this should be fully deterministic.
michael-schwarz
approved these changes
Sep 26, 2024
Although there are asserts, so update_suite doesn't complain about no checks.
Alright, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have cram from #787, it's a good time to use it to automate previously manual tests.
Changes
Add tests for YAML witness generation. The(Add cram tests for YAML witnesses #1357)yamlWitnessStrip
executable is used to remove non-deterministic metadata parts from the output.Fix(Cherry-picked before)ana.apron.invariant.one-var
not filtering enough.update_suite.rb
print test names that have no automatic checks. AddNOCRASH
,FIXPOINT
,NOTIMEOUT
andCRAM
annotations to suppress that by indicating which implicit aspect is being tested.TODO
Fix EvalAssert transformation to work on coreutil programs #855
Add missing annotations:(existing ones suppressed withNOCHECK
)Fix cram test failures on MacOS.