Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use hex string for blockNumber param in eth_getBlockReceipts #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use hex string for blockNumber param in eth_getBlockReceipts #26

wants to merge 1 commit into from

Conversation

lyfsn
Copy link

@lyfsn lyfsn commented Mar 11, 2024

This eth method eth_getBlockReceipts needs a hex string value block number as the first parameter.

Before this code is fixed, this error will occur.

2024/03/11 10:17:41 error doing requestReceipts for slot 43215: io-error when fetching tx-receipts: invalid argument 0: json: cannot unmarshal number into Go value of type string

@ohko4711
Copy link

@danielCalbonero12345 @guybrush hi,

Although RECEIPTS_MODE_BATCH can be used to circumvent this issue, merging this PR can maintain consistency of our code repo and the upstream. Any questions are welcome for further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielCalbonero12345 danielCalbonero12345 danielCalbonero12345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyfsn @ohko4711 @danielCalbonero12345