Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links between top-level deployment nodes in DeploymentView #18

Open
jlordiales opened this issue Mar 28, 2021 · 1 comment
Open

Links between top-level deployment nodes in DeploymentView #18

jlordiales opened this issue Mar 28, 2021 · 1 comment

Comments

@jlordiales
Copy link

jlordiales commented Mar 28, 2021

Hi folks!

After a few hours of debugging to figure out why the links between my containers were not being shown in my deployment view, I saw

model/expr/render.go

Lines 101 to 106 in 2461d2e

// Do not automatically add relationship views across different
// top-level deployment nodes.
//
// Note: this rule is a little bit arbitrary however it is possible
// to override the behavior using `Link` and `Unlink` explicitly in
// the design. We'll see how that works out over time.

While it is true that you can technically add them using Link, it's not a great DX. Would you be interested on a PR adding something like AddTopLevelLinks (similar to the current AddAll and AddDefault) that is only applicable inside a DeploymentView?

@raphael
Copy link
Member

raphael commented Nov 15, 2021

Sorry for the late reply! Yes that would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants