Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP send a broadcast #166

Open
jason155392 opened this issue Feb 21, 2024 · 8 comments
Open

CP send a broadcast #166

jason155392 opened this issue Feb 21, 2024 · 8 comments
Labels
API API related requests/issues Enhancement New feature or request

Comments

@jason155392
Copy link

Can CP send a broadcast to PD now?
I checked the API and found that only the osdp_cp_send_command function is available.
This function requires specifying the PD offset.
However, osdp_cp_setup cannot be set up with osdp_pd_info_t for the 0x7F address.
This will cause a "packet seq mismatch" issue.

How can libosdp handle this now?

@sidcha
Copy link
Member

sidcha commented Feb 21, 2024

The broadcast support that we have is entirely for the PD so if you need it for the CP, we should enable it. Can you describe what you are trying to achieve?

Also, as I recall, the broadcast message was underspecified in OSDP v2.2 for all practical purposes.

@jason155392
Copy link
Author

I want to implement a function to get/set a Peripheral Device's (PD) address using broadcast messages.

Initially, I'm considering the following approach:

  1. The Control Panel (CP) can send an "osdp_MFG" broadcast to check the PD's address.
  2. Subsequently, the CP can send an "osdp_COMSET" broadcast to set the PD's address.

I've reviewed OSDP v2.2, which specifies that "the use of the broadcast address should be limited to controlled (single PD) configurations."
Therefore, this method is suitable for closed environments, where the CP can utilize it to manage single PD information effectively.

@sidcha
Copy link
Member

sidcha commented Feb 22, 2024

Okay, that sounds compelling enough. Let me see how this can be implemented.

@sidcha sidcha added API API related requests/issues Enhancement New feature or request labels Feb 22, 2024
@sidcha
Copy link
Member

sidcha commented Feb 22, 2024

Looks like #113 can make use of this too.

@schmida2
Copy link
Contributor

Looks like #113 can make use of this too.

The proposed concept of OSDP auto addressing revision 2 does not rely on broadcast anymore, esp. because using broadcasts during operation sets back message sequence numbers (SQN) and this would harm the OSDP built-in error recovery

@sidcha
Copy link
Member

sidcha commented Mar 13, 2024

@schmida2 I turned #113 into a discussion. Do you mind updating that thread with the most recent version of your proposal? (I think the current link points to the one with broadcast messages)

The last comment has the most recent revision: https://github.com/schmida2/libosdp/blob/osdp-extension-autoaddr/OSDP_Extension-AutoAddressingProtocol.md

@dhopsonlb
Copy link

Is there any news on this functionality? We're using libosdp professionally and CP broadcast support is important for us.

@sidcha
Copy link
Member

sidcha commented Jul 20, 2024

@dhopsonlb, What use case are you targeting? Is it the same as @jason155392? If not, the solution I had in mind (relatively simpler approach) would not work for the general case "CP can send any command as broadcast".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related requests/issues Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants