Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming new param in (s)list_insert_node to newNode #26

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

dmercer-google
Copy link
Contributor

new is a keyword in C++ thus compiling with C++ causes issues with a param names new. Renaming the param to newNode eliminates this issue.

The compile error I was seeing was: error: invalid parameter name: 'new' is a keyword

@dmercer-google dmercer-google changed the title renaming new param in list_insert_node to newNode renaming new param in (s)list_insert_node to newNode Jan 9, 2024
@dmercer-google
Copy link
Contributor Author

@sidcha Any comment on this PR? new is a reserved word in c++.

@sidcha
Copy link
Member

sidcha commented Feb 15, 2024

Oops, sorry completely missed this one. LGTM, thanks for the fix

@sidcha sidcha merged commit 79dd8bd into goToMain:master Feb 15, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants