Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add denylists to work in conjunction with allowlists, for ease of access management. #999

Open
KellyMerrick opened this issue Sep 4, 2024 · 0 comments
Labels
feature Indicates a new feature

Comments

@KellyMerrick
Copy link
Contributor

KellyMerrick commented Sep 4, 2024

Description

We should have the ability to add a <thing> to a denylist, that used in conjunction with a corresponding allowlist, helps fine-tune access.

We currently have a Repo Allowlist and Schedule Allowlist. The addition of User Allowlist, Repo Denylist, Schedule Denylist, and User Denylist, greatly enhances the ability to quickly control access.

For example, if Repo Allowlist is set to the default * (all repos), but just a subset of org/repos should be blocked, we would have to individually add all org/* and/or org/repos to the list, except those to be blocked.

With both lists, we can still keep the allowlist to be * (all repos), but also have org/repo's in the denylist. Much easier to maintain.

Error messages should include appropriate amount of detail, tbd, perhaps clarifying blocked by admin, contact admin for access or similar.

One benefit is if an admin determines a repo needs to be blocked on the fly due to behavior affecting the platform, it can quickly be blocked so the admin can focus on troubleshooting.

Missed opportunity with Repo Allowlist: enabled repos that are no longer in the repo allow list should be blocked from running new builds.

  • If a repo is enabled, and then a platform admin removes it from the repo allow list (or the repo allow list is updated from all repos to only allow certain repos), current behavior is the repo is still able to run builds (restarts and new commits).

  • Ideal behavior is updating the repo allow list should prevent these builds.

Value

Platform admins can have confidence in which repos/users are allowed or prevented from running builds.

Useful Information

  1. What is the output of vela --version?

v0.24.0

  1. What operating system is being used?
  1. Any other important details?
@KellyMerrick KellyMerrick added bug Indicates a bug enhancement Indicates an improvement to a feature feature Indicates a new feature and removed bug Indicates a bug enhancement Indicates an improvement to a feature labels Sep 4, 2024
@KellyMerrick KellyMerrick changed the title Prevent enabled repos from running builds if it is no longer in the repo allow list. Feat: Add denylists to work in conjunction with allowlists, for ease of access management. Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

No branches or pull requests

1 participant