Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Implement class "shell" across all cli contextual help. #978

Open
KellyMerrick opened this issue May 29, 2024 · 0 comments
Open

UI: Implement class "shell" across all cli contextual help. #978

KellyMerrick opened this issue May 29, 2024 · 0 comments
Labels
area/ui Indicates a change to the UI enhancement Indicates an improvement to a feature

Comments

@KellyMerrick
Copy link
Contributor

KellyMerrick commented May 29, 2024

Description

The class "shell" adds a green $ to the beginning of cli commands, making the commands more visually appealing, aligning to a standard of representing terminal commands with a leading shell element.

It is already implemented here, but implementing it correctly for all contextual help by replacing the input block with code [ class "shell" ] [ text command.content ] is more scope than intended for the pr where it was initialized.

Additional work will be needed to remove related form-control elements and some additional spans, remove related classes that would then be redundant, adjust styling/alignment for $, etc.

Value

Visual appeal, consistent implementation across the site, replacing input and related form-control with more appropriate elements, as technically the contextual help is not a form.

Definition of Done

The class "shell" implemented across the site, replacing input/form usage.

Effort (Optional)

2 days

Impacted Personas (Optional)

Everyone

@KellyMerrick KellyMerrick added enhancement Indicates an improvement to a feature area/ui Indicates a change to the UI labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Indicates a change to the UI enhancement Indicates an improvement to a feature
Projects
None yet
Development

No branches or pull requests

1 participant