New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: investigate ContainerStop for build cancel #960

Open

plyr4 opened this issue Mar 25, 2024 · 0 comments

Labels

Contributor

plyr4 commented Mar 25, 2024 •

edited

Loading

Description

We kill containers rather harshly when builds are cancelled, we should explore using ContainerStop to apply a sigterm, wait, sigkill.

https://github.com/go-vela/worker/blob/main/runtime/docker/container.go#L63

plyr4 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment