Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server(tracing): add a ratio head-sampler #1007

Open
plyr4 opened this issue Sep 20, 2024 · 0 comments
Open

server(tracing): add a ratio head-sampler #1007

plyr4 opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement Indicates an improvement to a feature

Comments

@plyr4
Copy link
Contributor

plyr4 commented Sep 20, 2024

Description

we need a ratio-based sampler that works in conjunction with the rate limit sampler.

we should build it in a way that supports adding any number of samplers with a way to ensure they are prioritized consistently.

we should also figure out a way to use the per-task sampler config to control the ratio sampler. meaning, we should be able to rate-limit and ratio-sample both shared/globally AND for each task name following the pattern introduced in go-vela/server#1184

{
    "/metrics": {
        "active": true,
+        "ratio": 0.2, <- record 20% of total traces for this task
+        "persecond": 5 <- record 5 traces per second for this task
    }
}
@plyr4 plyr4 added the enhancement Indicates an improvement to a feature label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

No branches or pull requests

1 participant