Draft: Add support of discard with treshold option, remake the solution usin… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyckyta
force-pushed
the
master
branch
3 times, most recently
from
e645399
to
842ebfe
Compare
|
Should be fixed now, pls try again |
Pull Request Test Coverage Report for Build 10548914574Details
💛 - Coveralls |
nyckyta
force-pushed
the
master
branch
3 times, most recently
from
aa1b501
to
46402bc
Compare
|
Added few test cases that should fix the coverage, slightly improved the API. Pls, run the job |
added 2 commits
September 1, 2024 15:39
The change is inspired by the comment go-pkgz#5 (comment). The solution relies on channels as the main synchronization primitive, instead of semaphore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g channels
The change is inspired by the comment #5 (comment). The solution relies on channels as the main synchronization primitive, instead of semaphore.