Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support request - Unix socket support when running as DAP Client #3814

Open
n1lesh opened this issue Sep 21, 2024 · 2 comments
Open

Support request - Unix socket support when running as DAP Client #3814

n1lesh opened this issue Sep 21, 2024 · 2 comments

Comments

@n1lesh
Copy link

n1lesh commented Sep 21, 2024

Unix socket support was added here: #3654.

However, there's currently no way to initiate a connection from dlv dap to a server listening on a Unix socket. This feature is essential for extensions like vscode-go, which initiate a connection in reverse mode by running dlv dap with the client-addr flag and need to support Unix sockets.

I would love to hear your thoughts on this, and I’d be happy to give it a try.

@aarzilli
Copy link
Member

This feature is essential for extensions like vscode-go

Considering that vscode-go has been written and support for DAP over unix sockets doesn't exist, I wouldn't use the word "essential" here.

@n1lesh
Copy link
Author

n1lesh commented Sep 21, 2024

@aarzilli It becomes essential since I'm working on adding the support for unix sockets in vscode-go. That's how I got to know dlv dap can listen on a unix socket but cannot connect to one, at least when running the dap subcommand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants