Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors with Wayland on Debian 13 (trixie) using Clang 16 #48

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

pkgdemon
Copy link
Contributor

This pull request resolves several build errors encountered when compiling with Wayland support (./configure --enable-server=wayland) on Debian 13 Testing (codename trixie) using Clang version 16.0.6.

The updates include:

  • Selector Naming Issues: Corrected method declarations to properly align with Objective-C selector conventions.
  • Function Pointer Compatibility: Fixed mismatched function pointer types to align with expected signatures.
  • Implicit Declarations: Added necessary includes and declarations for Wayland functions to prevent implicit declaration errors.
  • Type Corrections: Adjusted type usage to match expected formats and avoid type mismatch errors.

If this PR is accepted, I will work on a follow-up PR will address additional build issues on Arch Linux with Clang 18.1.8.

Copy link
Member

@fredkiefer fredkiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you please check the few comments I left, then it's fine to merge this.

@fredkiefer fredkiefer merged commit d27af6a into gnustep:master Aug 28, 2024
3 checks passed
@pkgdemon
Copy link
Contributor Author

Also just wanted to leave a note to correct a statement made in my description. The build is working now with Arch Linux and clang 18. No additional PR will be needed for that.

onflapp added a commit to onflapp/libs-back that referenced this pull request Sep 3, 2024
Fix build errors with Wayland on Debian 13 (trixie) using Clang 16 (gnustep#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants