-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors with Wayland on Debian 13 (trixie) using Clang 16 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
reviewed
Aug 28, 2024
fredkiefer
reviewed
Aug 28, 2024
fredkiefer
reviewed
Aug 28, 2024
fredkiefer
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could you please check the few comments I left, then it's fine to merge this.
fredkiefer
approved these changes
Aug 28, 2024
Also just wanted to leave a note to correct a statement made in my description. The build is working now with Arch Linux and clang 18. No additional PR will be needed for that. |
onflapp
added a commit
to onflapp/libs-back
that referenced
this pull request
Sep 3, 2024
Fix build errors with Wayland on Debian 13 (trixie) using Clang 16 (gnustep#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves several build errors encountered when compiling with Wayland support (./configure --enable-server=wayland) on Debian 13 Testing (codename trixie) using Clang version 16.0.6.
The updates include:
If this PR is accepted, I will work on a follow-up PR will address additional build issues on Arch Linux with Clang 18.1.8.