Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine time handling and close 1649 #1652

Conversation

GillesDuvert
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (d42a346) 41.05% compared to head (34f33c8) 41.15%.
Report is 2 commits behind head on master.

❗ Current head 34f33c8 differs from pull request most recent head 5b1be3d. Consider uploading reports for the commit 5b1be3d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
+ Coverage   41.05%   41.15%   +0.09%     
==========================================
  Files         356      356              
  Lines       95091    95085       -6     
  Branches    19544    19530      -14     
==========================================
+ Hits        39044    39134      +90     
+ Misses      56047    55951      -96     
Files Coverage Δ
src/basic_pro.cpp 47.63% <100.00%> (+4.36%) ⬆️
src/calendar.cpp 77.94% <100.00%> (+45.58%) ⬆️
src/libinit.cpp 100.00% <100.00%> (ø)
src/plotting_device.cpp 47.50% <0.00%> (ø)
src/plotting.cpp 55.79% <31.70%> (-0.09%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert
Copy link
Contributor Author

closing --- the current work extends far beyond the purpose of this PR. Will be replaced by 1 or 2 PRs more specialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant