Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw column name if we cannot resolve it when building a query #52

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

dvdsgl
Copy link
Member

@dvdsgl dvdsgl commented Mar 7, 2024

This allows queries to refer to column names that are not statically known.

We only do this for the lefthand side of the comparison; the righthand side can either be a column name, or a string literal, and we assume it's a string literal if the client does not recognize the column name. If instead we assumed that any unknown column was valid, we would have to change how queries comparing string literals are written.

@dvdsgl dvdsgl merged commit 2c010f5 into main Mar 9, 2024
2 checks passed
@dvdsgl dvdsgl deleted the query-unknown-columns branch March 9, 2024 20:54
@dvdsgl dvdsgl self-assigned this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant