Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep focus in overlay editor #915

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BrianHung
Copy link
Collaborator

@BrianHung BrianHung commented Mar 9, 2024

Tries to fix #910

  • if an editor is a native html input or textarea, we use readOnly instead of disabled; this allows the element to be focus-able but not editable. Benefit of this is that selection still works if a person wants to copy the cell content.
  • for editors without a focusable element (and also editors in general), instead of using an invisible textarea with autofocus=true, we make the overlay editor focusable itself and autofocused on mount; shouldn't conflict with editors with autofocused elements since children renders after parent

We should add some tests to check that click within cell and then pressing escape works for each internal cell editor.

@BrianHung BrianHung marked this pull request as draft March 9, 2024 00:01
@BrianHung BrianHung marked this pull request as ready for review June 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape doesn't close cell overlay consistently
1 participant