Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onCellEdited fires for readonly cols when getCellsForSelection is set to true #987

Open
vydimitrov opened this issue Jul 29, 2024 · 0 comments

Comments

@vydimitrov
Copy link

vydimitrov commented Jul 29, 2024

Hello all, I just noticed that onCellEdited fires for readonly cols when getCellsForSelection is set to true. It seems the bug was introduced with version 6 since I was not able to reproduce it on version 5.

Steps to reproduce it:

  • Add 2 cols - one enabled and one disabled for editing, with readonly prop
  • Add fillHandle
  • Add getCellsForSelection
  • Drag the handle from the column you can edit to the column that you are not allow to edit
  • Check on onCellEdited: it fires for the column that has readonly set to true

You can reproduce it here as well: https://codesandbox.io/p/sandbox/lingering-glitter-xzj2fz?file=%2Fsrc%2FApp.tsx%3A62%2C2

If you remove/comment getCellsForSelection then onCellEdited doesn't fire and it works as expected.

I'd expect that onCellEdited won't fire since the column is read only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant