Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dependencies to ~- syntax rather than >= #189

Closed
paddyroddy opened this issue Sep 11, 2024 · 3 comments · May be fixed by #207
Closed

Change dependencies to ~- syntax rather than >= #189

paddyroddy opened this issue Sep 11, 2024 · 3 comments · May be fixed by #207
Assignees
@paddyroddy
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.

Comments

@paddyroddy
Copy link
Member

My concern is for example NumPy now has v2 (#163), the current syntax would allow that when the code doesn't necessarily support it yet.
@paddyroddy paddyroddy added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 11, 2024
@paddyroddy paddyroddy self-assigned this Sep 11, 2024
@Saransh-cpp
Copy link
Member

Would make sense to do this for NumPy, but I'd prefer not doing it for other dependencies - Should You Use Upper Bound Version Constraints?

@paddyroddy
Copy link
Member Author

Yeah, the calendar ones are less obvious. NumPy is what I was mainly thinking of.

paddyroddy added a commit that referenced this issue Sep 11, 2024
@paddyroddy
MNT: pin NumPy to v1 (until v2 is supported)
0ef5643 
Fixes (the necessary) bit of #189.
@paddyroddy paddyroddy mentioned this issue Sep 11, 2024
Closed
@paddyroddy paddyroddy linked a pull request Sep 11, 2024 that will close this issue
MNT: pin NumPy to v1 (until v2 is supported) #195
Closed
@paddyroddy paddyroddy mentioned this issue Sep 12, 2024
Open
@paddyroddy
Copy link
Member Author

Addressed in #207, can close for now as this issue itself isn't that important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Milestone
No milestone
2 participants
@paddyroddy @Saransh-cpp