Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @electron/remote #650

Open
bmulholland opened this issue Oct 3, 2023 · 3 comments · May be fixed by #654
Open

Remove @electron/remote #650

bmulholland opened this issue Oct 3, 2023 · 3 comments · May be fixed by #654
Labels
dependency Dependency updates priority:high Items of high importance. Applicable to all users or use-cases refactor Refactoring of existing feature

Comments

@bmulholland
Copy link
Collaborator

Usage of @electron/remote is discouraged

We can replace it with inter-process communication fairly easily, just need to do it piece by piece.

@setchy setchy added dependency Dependency updates refactor Refactoring of existing feature labels Jan 19, 2024
@setchy
Copy link
Member

setchy commented Apr 3, 2024

@bmulholland - would you mind confirming that this can be closed. I did a search and couldn't find any references to remote from the electron package directly. All seem to have been migrated to @electron/remote (thank you kindly)

@bmulholland
Copy link
Collaborator Author

All seem to have been migrated to @electron/remote

That's the package that is discouraged and shouldn't be used. From the linked article, about @electron/remote itself:

⚠️ Warning! This module has many subtle pitfalls. There is almost always a better way to accomplish your task than using this module. For example, ipcRenderer.invoke can serve many common use cases.

@setchy
Copy link
Member

setchy commented Apr 3, 2024

Oops! I misread it. I focused on this comment but missed the warning. Thanks for the correction 🙇

@electron/remote is a replacement for the built-in remote module in Electron, which is deprecated and will eventually be removed.

setchy added a commit that referenced this issue Jun 10, 2024
setchy added a commit that referenced this issue Jun 10, 2024
* refactor: main js

* refactor: main js

* Merge remote-tracking branch 'origin/main' into refactor/mainjs

* defer removal until #650 is resolved

* add comments to group sections
@setchy setchy added the priority:high Items of high importance. Applicable to all users or use-cases label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates priority:high Items of high importance. Applicable to all users or use-cases refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants