Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fine-grained personal access token auth #1492

Open
setchy opened this issue Aug 25, 2024 · 3 comments
Open

Add support for fine-grained personal access token auth #1492

setchy opened this issue Aug 25, 2024 · 3 comments
Labels
blocked Is blocked by another issue or dependency enhancement New feature or enhancement to existing functionality

Comments

@setchy
Copy link
Member

setchy commented Aug 25, 2024

πŸ“ Provide a description of the new feature

Currently we support the GitHub personal access tokens (classic)

This ticket is to enhance Gitify to also support fine-grained personal access tokens which are still in beta

βž• Additional Information

No response

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Aug 25, 2024
@setchy setchy changed the title Feature: Add support for fine-grained token Add support for fine-grained personal access token auth Aug 25, 2024
@setchy setchy added the blocked Is blocked by another issue or dependency label Aug 29, 2024
@setchy
Copy link
Member Author

setchy commented Aug 29, 2024

From GitHub Support when clarifying misleading documentation of https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#list-notifications-for-the-authenticated-user%5D

Thank you for reaching out to GitHub Support!

That section of the documentation is incorrect -- thank you for bringing this to our attention. At the moment, all notification API endpoints only support authentication using personal access token classic: https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#about-github-notifications

These endpoints only support authentication using a personal access token (classic). For more information, see "[Managing your personal access tokens](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token)."

GitHub Apps and Fine-grained token isn't currently supported. I can see why this is misleading, I'd reach out to the relevant teams to have this docs updated to avoid confusion. The PM also mentioned this here about FPAT not currently supporting Notifications API.

Please let me know if there is anything else I can assist with.

Best,

GitHub Support

Documentation has since been updated

@bmulholland
Copy link
Collaborator

At least they acknowledged it and quickly fixed the docs! Sucks it wasted your time though.

@setchy
Copy link
Member Author

setchy commented Aug 30, 2024

Added to #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Is blocked by another issue or dependency enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants