CPP: Add query for CWE-783 Operator Precedence Logic Error When Use Bitwise Or Logical Operations #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Jul 20, 2021
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Outdated
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Outdated
Show resolved
Hide resolved
cpp/ql/test/experimental/query-tests/Security/CWE/CWE-783/semmle/tests/test.cpp
Outdated
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Outdated
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Outdated
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Outdated
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Show resolved
Hide resolved
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Show resolved
Hide resolved
MathiasVP
reviewed
Jul 20, 2021
...mental/Security/CWE/CWE-783/OperatorPrecedenceLogicErrorWhenUseBitwiseOrLogicalOperations.ql
Show resolved
Hide resolved
Co-authored-by: Mathias Vorreiter Pedersen <[email protected]>
|
I will definitely see how to strengthen the test file for all your suggestions. |
…eLogicErrorWhenUseBitwiseOrLogicalOperations.ql Co-authored-by: Mathias Vorreiter Pedersen <[email protected]>
|
Good afternoon @MathiasVP. |
|
Everything looks good! The only change needed now is to autoformat the QL file to make our CI check happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day.
in this request I am looking for possible priority errors when using logical and bit operations.
I would like to draw your attention to the
isRealRangepredicate, unfortunately, the restriction onintdid not allow usingbitShiftRightand make it more elegant.search results in real software.
Andarix/simutrans#2
rui314/chibicc#54