Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brodes/overflow buffer fixes upstream #17384

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Brodes/overflow buffer fixes upstream #17384

merged 11 commits into from
Sep 11, 2024

Conversation

bdrodes
Copy link
Contributor

@bdrodes bdrodes commented Sep 4, 2024

Changes in Buffer.qll and BuferAccess.qll to address false positives in cpp/overflow-buffer

@bdrodes bdrodes requested a review from a team as a code owner September 4, 2024 16:54
geoffw0
geoffw0 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issues in the tests. All LGTM now, and I did a DCA run on this branch which looks clean as well.

@geoffw0 geoffw0 merged commit d374935 into github:main Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdrodes @geoffw0