Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rainbowkit patch version to be able to override logos of existing chains #3463

Merged
merged 5 commits into from
May 24, 2024
Merged

update rainbowkit patch version to be able to override logos of existing chains #3463

merged 5 commits into from
May 24, 2024

Conversation

gravityblast
Copy link
Contributor

Fixes: #issue

Description

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@gravityblast gravityblast requested review from a team as code owners May 23, 2024 16:03
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:12pm

@gravityblast gravityblast marked this pull request as draft May 23, 2024 16:03
@gravityblast gravityblast marked this pull request as ready for review May 24, 2024 09:42
@gravityblast gravityblast changed the title [WIP] update rainbowkit patch version to be able to override logos of existing chains update rainbowkit patch version to be able to override logos of existing chains May 24, 2024
MasterHW
MasterHW approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@MasterHW MasterHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! background was a lifesaver

@MasterHW MasterHW merged commit f6b3ab7 into main May 24, 2024
14 checks passed
@MasterHW MasterHW deleted the update-rainbow-to-1.0.12 branch May 24, 2024 16:15
@MasterHW MasterHW mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

@MasterHW MasterHW MasterHW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gravityblast @bhargavaparoksham @MasterHW