Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve builder default envs #3444

Merged
merged 3 commits into from
May 20, 2024
Merged

improve builder default envs #3444

merged 3 commits into from
May 20, 2024

Conversation

MasterHW
Copy link
Contributor

Fixes: bug "REACT_APP_CHAINS_OVERRIDE=all" is not valid, and commenting out this line will actually have the desired effect. Also, make allo-v2 the default.

Description

Improve default/example env values to more closely reflect "ideal" default values.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@MasterHW MasterHW requested review from a team as code owners May 15, 2024 19:25
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:34pm

@thelostone-mc thelostone-mc merged commit 809d2b3 into main May 20, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the builder-envs branch May 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants