Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payout issue in v2 #3440

Merged
merged 6 commits into from
May 16, 2024
Merged

fix: payout issue in v2 #3440

merged 6 commits into from
May 16, 2024

Conversation

bhargavaparoksham
Copy link
Contributor

Fixes: #issue

Description

fix: payout issue in v2

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@bhargavaparoksham bhargavaparoksham requested review from a team as code owners May 15, 2024 12:31
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:05am

Copy link

sentry-io bot commented May 15, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/common/src/allo/backends/allo-v2.ts

Function Unhandled Issue
getStrategyAddress Error: ZkSync era mainnet is not supported getStr...
Event Count: 1 Affected Users: 3

Did you find this useful? React with a 👍 or 👎

Copy link
Member

@meglister meglister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested at https://manager-git-fix-v2-payout-grants-stack.vercel.app/#/round/11 and verified 1 grantee was showing as paid. i successfully paid out the 2nd grantee and both are showing as paid in the UI

@bhargavaparoksham bhargavaparoksham merged commit 8638547 into main May 16, 2024
14 checks passed
@bhargavaparoksham bhargavaparoksham deleted the fix-v2-payout branch May 16, 2024 12:44
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
* fix: payout issue in v2

* fix: anchor adress issue

* wip

* Revert "disabled payout (gitcoinco#3441)" (gitcoinco#3443)

This reverts commit 42c5b61.

* remove log

* rm: generateMerkleTree from utils

---------

Co-authored-by: Aditya Anand M C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants