Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG: Add payout token list #3436

Merged
merged 7 commits into from
May 20, 2024
Merged

DG: Add payout token list #3436

merged 7 commits into from
May 20, 2024

Conversation

0xKurt
Copy link
Member

@0xKurt 0xKurt commented May 14, 2024

Changes on Direct Grants:

This PR allows to remove the payout token from the Direct Grants Round creation form,
also it resolves the bug of setting a wrong/not existing token.

As a replacement for the pre-defined token a token list dropdown was added to the payout form.
The dropdown allows to chose a token form our payout token list and to payout with a custom token.

To Test:

  • creating a direct grants round (without payout token)
  • payout a grantee with a token from the dropdown
  • payout a grantee with a custom token (i can send you some test token)

Screenshots:
image
Note: RND is a Random token i used for testing which is not in the payout token list

image
Custom token allows to paste in an address and loads the needed token information like symbol and decimals

image
a wrong token address shows an error

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:17am

Copy link

sentry-io bot commented May 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/round-manager/src/features/round/ApplicationDirectPayout.tsx

Function Unhandled Issue
ApplicationDirectPayout Error: "Payout token" not found in answers! Appli...
Event Count: 3 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@thelostone-mc thelostone-mc marked this pull request as ready for review May 16, 2024 06:11
@thelostone-mc thelostone-mc requested review from a team as code owners May 16, 2024 06:11
@thelostone-mc thelostone-mc requested a review from a team as a code owner May 16, 2024 06:11
Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thelostone-mc thelostone-mc merged commit 4681eb2 into main May 20, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the dg-payout-token branch May 20, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants