Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donations/when application is null #3411

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

codenamejason
Copy link
Contributor

Using this one as an example:

https://explorer.gitcoin.co/#/contributors/0xd034Fd34eaEe5eC2c413C51936109E12873f4DA5

Screenshot 2024-05-03 at 2 17 33 PM

Fixes: Donations loading an empty screen

Description

Adds a check for any applications that are null.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:30pm

@codenamejason codenamejason merged commit 1c827b0 into main May 3, 2024
14 checks passed
@codenamejason codenamejason deleted the fix--donations-page branch May 3, 2024 18:59
0xKurt added a commit that referenced this pull request May 8, 2024
Author:    0xKurt <[email protected]>

fix: donations/when application is null (#3411)

* fix: donations/when application is null

* remove log

updated url

update env

fix tests

remove react() plugin

fix placeholder error
thelostone-mc pushed a commit that referenced this pull request May 8, 2024
Author:    0xKurt <[email protected]>

fix: donations/when application is null (#3411)

* fix: donations/when application is null

* remove log

updated url

update env

fix tests

remove react() plugin

fix placeholder error
thelostone-mc added a commit that referenced this pull request May 13, 2024
* feat: add direct grants v2

Author:    0xKurt <[email protected]>

fix: donations/when application is null (#3411)

* fix: donations/when application is null

* remove log

updated url

update env

fix tests

remove react() plugin

fix placeholder error

* changed v1/v2 switch

* regenerate lock

* temp update switch for dg v2

* fix

* rm log

* recipientsCounter

* fix bug

* fix

---------

Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: Jaxcoder <[email protected]>
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
* fix: donations/when application is null

* remove log
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
* feat: add direct grants v2

Author:    0xKurt <[email protected]>

fix: donations/when application is null (gitcoinco#3411)

* fix: donations/when application is null

* remove log

updated url

update env

fix tests

remove react() plugin

fix placeholder error

* changed v1/v2 switch

* regenerate lock

* temp update switch for dg v2

* fix

* rm log

* recipientsCounter

* fix bug

* fix

---------

Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: Jaxcoder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants