Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipient data on checkout #3384

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Update recipient data on checkout #3384

merged 1 commit into from
Apr 26, 2024

Conversation

0xKurt
Copy link
Member

@0xKurt 0xKurt commented Apr 26, 2024

Some user have Carts with broken items from previous bugs.
This PR introduces an additional call to the indexer to query and update the application data.

Note: We may want to revert this change in future.

Fixes: #issue

Description

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:03pm

@0xKurt 0xKurt marked this pull request as ready for review April 26, 2024 13:50
@0xKurt 0xKurt requested review from a team as code owners April 26, 2024 13:50
@thelostone-mc
temp-fix: fetch anchor address at checkout
c34e5a0 
note: this needs to be reverted (this is temp fix to ensure cart
with projects having no anchor can checkout)
@thelostone-mc thelostone-mc merged commit 3ad94ed into main Apr 26, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the fix branch April 26, 2024 14:33
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
@0xKurt @thelostone-mc @debuggingfuture
temp-fix: fetch anchor address at checkout (gitcoinco#3384)
cc425a9 
note: this needs to be reverted (this is temp fix to ensure cart
with projects having no anchor can checkout)

Co-authored-by: Aditya Anand M C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@codenamejason codenamejason codenamejason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xKurt @thelostone-mc @codenamejason