Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager changes for Passport Lite x Cluster Match MVP #3336

Merged
merged 19 commits into from
May 8, 2024
Merged

Manager changes for Passport Lite x Cluster Match MVP #3336

merged 19 commits into from
May 8, 2024

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented Apr 19, 2024 •
edited
Loading

Fixes: #3131

Description

Manager: frontend changes for Passport Lite x Cluster Match MVP

  • During round creation you see the option to select Passport Lite i.e Model based Passport score option
  • In a Passport Lite round when you go to the Round Results Page, you see the option to upload custom cluster match results.
  • In a non passport lite round you see the recommended option & also an option to upload you custom results.

Rounds that you can use to test:

Note: roundId is the one after /round in the url below.

  1. Passport Lite round: https://manager-git-manager-3131-grants-stack.vercel.app/#/round/49
    Cluster match notebook link for this round: https://qf-calculator.streamlit.app/?round_id=49&chain_id=42161
  2. Round with passport disabled: https://manager-git-manager-3131-grants-stack.vercel.app/#/round/11
  3. Round where results are finalised: https://manager-git-manager-3131-grants-stack.vercel.app/#/round/6

loom: https://www.loom.com/share/8813f7a60fae4098a78ae8f53c04f895?sid=5fc11447-07d2-4f25-b7a6-f6e62a9e6b9e

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am

@bhargavaparoksham bhargavaparoksham merged commit 0463be6 into main May 8, 2024
14 checks passed
@bhargavaparoksham bhargavaparoksham deleted the manager-3131 branch May 8, 2024 02:17
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
@bhargavaparoksham @debuggingfuture
Manager changes for Passport Lite x Cluster Match MVP (gitcoinco#3336)
6021d8d 
* feat: add auto sybil screening option

* fix: build issues

* feat: add different matching distribution options for different sybilDefence types

* feat: addIsRecommendedDistribution

* feat: make round results page code modular

* feat: add UploadCustomResults option in round results

* feat: useMatchCSVParser

* feat: handle custom results

* fix: pnpm issue

* fix: type issue

* fix: type name issues

* fix: address design feedback

* fix: post payout issue

* feat: update sybilDefense type

* feat: rm isRoundUsingPassportLite

* feat: update isSybilDefenseEnabled to handle new type

* fix: pnpm lock file issue

* fix: build issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boudra boudra boudra approved these changes

@melissa-neira melissa-neira melissa-neira approved these changes

Assignees
No one assigned
Labels
Feature Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manager: frontend changes for Passport Lite x Cluster Match MVP
4 participants
@bhargavaparoksham @boudra @melissa-neira @codenamejason