Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/3297 Add Explore Projects Tab #3328

Merged
merged 6 commits into from
Apr 24, 2024
Merged

WIP/3297 Add Explore Projects Tab #3328

merged 6 commits into from
Apr 24, 2024

Conversation

codenamejason
Copy link
Contributor

@codenamejason codenamejason commented Apr 18, 2024

Fixes: #3297

Description

Add back the Explore Projects tab with search feature.

Screenshot 2024-04-23 at 7 33 58 PM

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 11:52am

@codenamejason
Copy link
Contributor Author

@0xKurt Everything is rebased with the collections from @gravityblast and the search input is added back. I am not liking the results so far for the search.

@thelostone-mc thelostone-mc marked this pull request as ready for review April 24, 2024 11:48
@thelostone-mc thelostone-mc requested review from a team as code owners April 24, 2024 11:48
@thelostone-mc thelostone-mc merged commit db081d9 into main Apr 24, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the proj-tab branch April 24, 2024 11:56
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
* fix

* update tabs based on collections pr

* fix conflict errors

* show search input/not working very well for results

* Update packages/grant-explorer/src/features/contributors/ViewContributionHistory.tsx

---------

Co-authored-by: 0xKurt <[email protected]>
Co-authored-by: Aditya Anand M C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GG20 - Explore Projects tab
3 participants