Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: builder applyToRound #2926

Merged
merged 12 commits into from
Feb 14, 2024
Merged

v2: builder applyToRound #2926

merged 12 commits into from
Feb 14, 2024

Conversation

0xKurt
Copy link
Member

@0xKurt 0xKurt commented Feb 12, 2024

Description

Flows affected and tested

  • Apply To Round on V1 QF
  • Apply To Round on V2 QF when both project and round are on same chain

NOTE:

Fixes: #2788

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:28pm

cache/solidity-files-cache.json Outdated Show resolved Hide resolved
Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @0xKurt / @codenamejason / @thelostone-mc -

Confirming I was able to apply to a round on OP with a project on OP on v1!

For v2, I'm pretty sure I can't test this until @boudra 's create round on v2 PR is live - is that correct?

When I try to load an existing round's application in the staging v2 environment, this is what I see:
Screen Shot 2024-02-14 at 11 52 29 AM

@0xKurt
Copy link
Member Author

0xKurt commented Feb 14, 2024

hey @0xKurt / @codenamejason / @thelostone-mc -

Confirming I was able to apply to a round on OP with a project on OP on v1!

For v2, I'm pretty sure I can't test this until @boudra 's create round on v2 PR is live - is that correct?

When I try to load an existing round's application in the staging v2 environment, this is what I see: Screen Shot 2024-02-14 at 11 52 29 AM

You may need to go to the frontend first and switch to v2.
The round should be open for the next 3 days: https://builder-staging-git-2788-builder-applytoround-grants-stack.vercel.app/#/chains/80001/rounds/2

@michellema1208
Copy link
Contributor

@0xKurt / @codenamejason / @thelostone-mc -- I shared this on Discord but resharing here just in case: when I load the application link shared above, it redirects me to the Zuzalu round: https://builder-staging-git-2788-builder-applytoround-grants-stack.vercel.app/#/chains/80001/rounds/2

I don't believe that's right? I've already switched to Allo v2 version as well.

Screen Shot 2024-02-14 at 12 47 13 PM

@0xKurt
Copy link
Member Author

0xKurt commented Feb 14, 2024

@0xKurt / @codenamejason / @thelostone-mc -- I shared this on Discord but resharing here just in case: when I load the application link shared above, it redirects me to the Zuzalu round: https://builder-staging-git-2788-builder-applytoround-grants-stack.vercel.app/#/chains/80001/rounds/2

I don't believe that's right? I've already switched to Allo v2 version as well.

Screen Shot 2024-02-14 at 12 47 13 PM

That's the right one
We used it as test meta data

@michellema1208
Copy link
Contributor

@0xKurt - oh gotcha, so this isn't the actual Zuzalu application, just a test copy with the same metadata. Just making sure I wasn't applying to the actual Zuzalu round / there was an indexing error where other applications on other chains with the same ID are showing up!

Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming I'm able to test both of the following use cases:

Apply To Round on V1 QF
Apply To Round on V2 QF when both project and round are on same chain

Copy link

gitstream-cm bot commented Feb 14, 2024

This PR is 60.62962962962963% new code.

@codenamejason codenamejason merged commit af7ce95 into main Feb 14, 2024
19 checks passed
@codenamejason codenamejason deleted the 2788-builder-applyToRound branch February 14, 2024 22:26
Copy link

gitstream-cm bot commented Feb 14, 2024

🥷 Code experts: codenamejason, bhargavaparoksham

0xKurt, codenamejason have most 👩‍💻 activity in the files.
vacekj, codenamejason have most 🧠 knowledge in the files.

See details

packages/builder/.gitignore

Activity based on git-commit:

0xKurt codenamejason
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
vacekj: 7%

packages/builder/package.json

Activity based on git-commit:

0xKurt codenamejason
FEB 1 additions & 0 deletions
JAN 2 additions & 1 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
vacekj: 17%
codenamejason: 2%

packages/builder/src/__tests__/components/application/Form.test.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 2 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 16%
vacekj: 1%

packages/builder/src/actions/grantsMetadata.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 59 additions & 165 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 42%

packages/builder/src/actions/projects.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 57 additions & 94 deletions 87 additions & 172 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 23%
vacekj: 5%

packages/builder/src/actions/roundApplication.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 6 additions & 6 deletions 62 additions & 52 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 16%

packages/builder/src/actions/rounds.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 37 additions & 268 deletions 4 additions & 5 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 1%

packages/builder/src/components/application/Form.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 6 additions & 6 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 12%

packages/builder/src/components/application/FullPreview.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 6 additions & 3 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
vacekj: 97%

packages/builder/src/components/grants/ApplicationCard.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 40 additions & 34 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 24%

packages/builder/src/components/grants/rounds/RoundListItem.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 6 additions & 5 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 64%

packages/builder/src/components/rounds/Apply.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 5 additions & 3 deletions 5 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 19%

packages/builder/src/components/rounds/Show.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 9 additions & 4 deletions 3 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 13%
vacekj: 1%

packages/builder/src/components/rounds/ViewApplication.tsx

Activity based on git-commit:

0xKurt codenamejason
FEB 16 additions & 13 deletions 5 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 2%

packages/builder/src/reducers/projects.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 8 additions & 28 deletions 1 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 17%

packages/builder/src/reducers/rounds.ts

Activity based on git-commit:

0xKurt codenamejason
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 2%

packages/builder/src/types/index.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 3 additions & 9 deletions 2 additions & 11 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 15%
vacekj: 1%

packages/builder/src/utils/components.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 7 additions & 2 deletions 1 additions & 1 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 10%

packages/common/src/allo/backends/allo-v2.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 117 additions & 31 deletions
JAN 192 additions & 13 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 38%
vacekj: 6%

packages/common/src/index.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 12 additions & 10 deletions
JAN 24 additions & 0 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
vacekj: 49%
codenamejason: 3%

packages/data-layer/src/data.types.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 50 additions & 2 deletions 132 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 29%
vacekj: 9%

packages/data-layer/src/queries.ts

Activity based on git-commit:

0xKurt codenamejason
FEB 50 additions & 0 deletions 153 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 46%
vacekj: 11%

pnpm-lock.yaml

Activity based on git-commit:

0xKurt codenamejason
FEB 838 additions & 640 deletions 2218 additions & 1448 deletions
JAN 218 additions & 205 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
vacekj: 69%
codenamejason: 1%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update builder applyToRound flow to use anchor + the new wrapper
5 participants