Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move application page fetcher to data layer #2902

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Feb 7, 2024

Fixes: #2851

Description

moves the application page fetcher to data layer

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

carlbarrdahl and others added 30 commits November 23, 2023 10:17
…-indexer-data

# Conflicts:
#	packages/grant-explorer/src/features/round/ViewProjectDetails.tsx
#	packages/grant-explorer/src/features/round/__tests__/ViewProjectDetails.test.tsx
Copy link

gitstream-cm bot commented Feb 13, 2024

🥷 Code experts: carlbarrdahl, codenamejason

carlbarrdahl, codenamejason have most 👩‍💻 activity in the files.
codenamejason, carlbarrdahl have most 🧠 knowledge in the files.

See details

.gitignore

Activity based on git-commit:

carlbarrdahl codenamejason
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:

packages/data-layer/src/data-layer.ts

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 184 additions & 9 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 32%

packages/data-layer/src/data.types.ts

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 132 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 31%

packages/data-layer/src/queries.ts

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 153 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 58%

packages/grant-explorer/src/features/projects/hooks/__tests__/useApplication.test.tsx

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 32 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
carlbarrdahl: 100%

packages/grant-explorer/src/features/projects/hooks/useApplication.ts

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 154 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
carlbarrdahl: 100%

packages/grant-explorer/src/features/round/ViewProjectDetails.tsx

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 45 additions & 63 deletions
JAN 273 additions & 356 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
carlbarrdahl: 45%
codenamejason: 1%

packages/grant-explorer/src/features/round/__tests__/ViewProjectDetails.test.tsx

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 155 additions & 134 deletions
JAN 23 additions & 21 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
carlbarrdahl: 41%
codenamejason: 12%

packages/grant-explorer/src/index.tsx

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 12 additions & 9 deletions
JAN
DEC
NOV
OCT 2 additions & 3 deletions
SEP

Knowledge based on git-blame:
codenamejason: 11%

pnpm-lock.yaml

Activity based on git-commit:

carlbarrdahl codenamejason
FEB 2218 additions & 1448 deletions
JAN
DEC
NOV 47 additions & 45 deletions
OCT
SEP

Knowledge based on git-blame:
codenamejason: 3%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Feb 13, 2024

This PR is 24.69426152398871% new code.

@gravityblast gravityblast merged commit 0bd1dea into main Feb 13, 2024
19 checks passed
@gravityblast gravityblast deleted the 2851-explorer-v2-view-round-explorer-application-page-move-queries-to-data-layer branch February 13, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer application page: move queries to data layer
6 participants