Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary fix: active rounds sorting #2869

Merged
merged 10 commits into from
Feb 2, 2024
Merged

temporary fix: active rounds sorting #2869

merged 10 commits into from
Feb 2, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Feb 2, 2024

Fixes: #issue

Description

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners February 2, 2024 12:29
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:17pm

@boudra boudra changed the title fix active rounds sorting temporary fix: active rounds sorting Feb 2, 2024
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Feb 2, 2024

This PR is 23.595505617977526% new code.

@boudra boudra merged commit c3937b6 into main Feb 2, 2024
18 of 19 checks passed
@boudra boudra deleted the fix-active-rounds branch February 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vacekj vacekj vacekj approved these changes

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

Assignees
No one assigned
Labels
1 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boudra @vacekj @bhargavaparoksham