Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common, make it an actual package #2820

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix common, make it an actual package #2820

merged 2 commits into from
Jan 16, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Jan 16, 2024

Fixes: #issue

Description

This makes common isolated from the consumers, as it needs to build the JS code and types and they are included.

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners January 16, 2024 11:36
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:40am

Copy link

gitstream-cm bot commented Jan 16, 2024

🥷 Code experts: vacekj, gravityblast

vacekj, gravityblast have most 👩‍💻 activity in the files.
vacekj, gravityblast have most 🧠 knowledge in the files.

See details

.github/workflows/common.yml

Activity based on git-commit:

vacekj gravityblast
JAN
DEC
NOV
OCT 36 additions & 1 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 97%

package.json

Activity based on git-commit:

vacekj gravityblast
JAN
DEC 3 additions & 3 deletions
NOV
OCT 9 additions & 7 deletions
SEP 10 additions & 6 deletions
AUG

Knowledge based on git-blame:
vacekj: 26%

packages/common/package.json

Activity based on git-commit:

vacekj gravityblast
JAN
DEC
NOV
OCT 5 additions & 1 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 71%

packages/common/src/chains.ts

Activity based on git-commit:

vacekj gravityblast
JAN
DEC
NOV 0 additions & 1 deletions 229 additions & 0 deletions
OCT 39 additions & 0 deletions
SEP 6 additions & 0 deletions
AUG

Knowledge based on git-blame:
gravityblast: 64%
vacekj: 22%

pnpm-lock.yaml

Activity based on git-commit:

vacekj gravityblast
JAN
DEC 1755 additions & 1755 deletions
NOV 678 additions & 828 deletions 892 additions & 928 deletions
OCT 216 additions & 68 deletions
SEP 5514 additions & 9303 deletions
AUG 7291 additions & 5024 deletions

Knowledge based on git-blame:
vacekj: 64%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 16, 2024

This PR is 85.3211009174312% new code.

Copy link

gitstream-cm bot commented Jan 16, 2024

This PR is 86.08695652173914% new code.

@boudra boudra merged commit 1f4f1cf into main Jan 16, 2024
20 checks passed
@boudra boudra deleted the fix/common branch January 16, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants