Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow jpeg files in image upload dialog in builderˆ #2810

Merged

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Jan 12, 2024

Fixes: #2584

Description

fixes the image upload dialog in builder not accepting jpegs

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vacekj vacekj requested review from a team as code owners January 12, 2024 13:15
@vacekj vacekj linked an issue Jan 12, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm
builder-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm
explorer ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm
explorer-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm
manager ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm
manager-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:16pm

Copy link

gitstream-cm bot commented Jan 12, 2024

🥷 Code experts: gravityblast, digitalmnt

gravityblast has most 👩‍💻 activity in the files.
digitalmnt, gravityblast have most 🧠 knowledge in the files.

See details

packages/builder/src/components/base/ImageInput.tsx

Activity based on git-commit:

gravityblast
JAN
DEC
NOV 3 additions & 2 deletions
OCT
SEP
AUG

Knowledge based on git-blame:
digitalmnt: 70%
gravityblast: 26%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 12, 2024

This PR is 50% new code.

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vacekj vacekj merged commit a7b9bcf into main Jan 14, 2024
20 checks passed
@vacekj vacekj deleted the 2584-jpeg-is-not-in-ui-for-logo-and-banner-sections-in-builders branch January 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.jpeg is not in UI for Logo and Banner sections in builders
4 participants