Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rolling applications bug on edit page #2809

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Jan 12, 2024

Fixes: #2580

Description

this fixes the bugs described in the original ticket by Meg.
A follow-up to this ticket is a refactor of the Round Settings page, since it's currently a mess.

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:08pm
builder-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:08pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 1:08pm
explorer-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:08pm
manager ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:08pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 1:08pm

Copy link

gitstream-cm bot commented Jan 12, 2024

🥷 Code experts: bhargavaparoksham, codenamejason

bhargavaparoksham has most 👩‍💻 activity in the files.
codenamejason, bhargavaparoksham have most 🧠 knowledge in the files.

See details

packages/round-manager/src/features/round/ViewRoundSettings.tsx

Activity based on git-commit:

bhargavaparoksham
JAN
DEC
NOV 321 additions & 195 deletions
OCT 449 additions & 453 deletions
SEP
AUG

Knowledge based on git-blame:
codenamejason: 60%
bhargavaparoksham: 26%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 12, 2024

This PR is 41.01123595505618% new code.

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vacekj vacekj merged commit 8720219 into main Jan 15, 2024
19 checks passed
@vacekj vacekj deleted the 2580-selecting-enable-rolling-applications-in-round-edit-flow-does-not-change-app-end-date branch January 15, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting "Enable Rolling Applications" in round edit flow does not change app end date
3 participants