Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ethers transaction sender #2808

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Jan 12, 2024

Fixes: #issue

Description

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners January 12, 2024 11:02
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 11:03am
builder-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 11:03am
explorer ✅ Ready (Inspect) Visit Preview Jan 12, 2024 11:03am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 11:03am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 11:03am
manager-staging ✅ Ready (Inspect) Visit Preview Jan 12, 2024 11:03am

Copy link

gitstream-cm bot commented Jan 12, 2024

🥷 Code experts: no user but you matched threshold 10

boudra has most 👩‍💻 activity in the files.
boudra has most 🧠 knowledge in the files.

See details

packages/common/src/allo/transaction-sender.ts

Activity based on git-commit:

boudra
JAN 182 additions & 0 deletions
DEC
NOV
OCT
SEP
AUG

Knowledge based on git-blame:
boudra: 100%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 12, 2024

This PR is 100% new code.

@boudra boudra merged commit c956b6f into main Jan 16, 2024
24 checks passed
@boudra boudra deleted the feat/ethers-transaction-sender branch January 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants