Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scroll testnet #2797

Closed
wants to merge 11 commits into from
Closed

Add support for scroll testnet #2797

wants to merge 11 commits into from

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented Jan 9, 2024

Fixes: #2777

Description

Add support for scroll testnet

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:37pm

@@ -99,6 +101,19 @@ export const zkSyncEraTestnet: Chain = {
},
};

export const scrollTestnet: Chain = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll sepolia should be available as a chain from viem/chains here.

chainId: ChainId.SCROLL_TESTNET,
address: "0xc2332031de487f430fae3290c05465d907785eda",
decimal: 18,
logo: TokenNamesAndLogos["DAI"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have a test logo let's use that instead of DAI to not mislead the user

@michellema1208
Copy link
Contributor

hey @bhargavaparoksham - running into a few issues:

  • I'm not able to apply to a round on Scroll, and it looks like it's due to a LIT error:
Screen Shot 2024-01-10 at 9 44 17 AM
  • The Builder "My Projects" page generally takes a really long time to load, and also seems to be missing Scroll Sepolia projects
Screen Shot 2024-01-10 at 9 45 55 AM

Copy link
Contributor

@vacekj vacekj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrollTestnet is ambiguous as a chain name, since there was previously a scroll alpha testnet, and there will be new testnets in the future. let's call it scrollSepolia to disambiguate.

Copy link

gitstream-cm bot commented Jan 11, 2024

This PR is 96.74418604651163% new code.

@gravityblast
Copy link
Contributor

closing for now since LIT doesn't support scroll testnet

@thelostone-mc thelostone-mc deleted the scroll-2777 branch October 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Scroll] All: Add Scroll Sepolia testnet as a network on Grants Stack
4 participants