Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix round loading error on builder #2794

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix round loading error on builder #2794

merged 1 commit into from
Jan 10, 2024

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented Jan 9, 2024

Fixes: #2783

Description

Fix round application loading error on builder on polygon

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@bhargavaparoksham bhargavaparoksham requested review from a team as code owners January 9, 2024 08:40
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:21am

Copy link

gitstream-cm bot commented Jan 9, 2024

This PR is 50% new code.

Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to successfully apply!

Copy link

gitstream-cm bot commented Jan 9, 2024

🥷 Code experts: gravityblast

bhargavaparoksham has most 👩‍💻 activity in the files.
gravityblast, bhargavaparoksham have most 🧠 knowledge in the files.

See details

packages/builder/src/actions/rounds.ts

Activity based on git-commit:

bhargavaparoksham
JAN
DEC
NOV
OCT 49 additions & 4 deletions
SEP
AUG

Knowledge based on git-blame:
gravityblast: 21%
bhargavaparoksham: 13%

To learn more about /:\ gitStream - Visit our Docs

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bhargavaparoksham bhargavaparoksham merged commit 77e39df into main Jan 10, 2024
19 checks passed
@bhargavaparoksham bhargavaparoksham deleted the bug-2783 branch January 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application fails to load in builder
4 participants