Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkUSD as payout token for direct grants #2766

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented Jan 3, 2024

Fixes: #2762

Description

Add mkUSD as payout token for direct grants

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@bhargavaparoksham bhargavaparoksham requested review from a team as code owners January 3, 2024 13:21
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 2:40pm

@michellema1208
Copy link
Contributor

michellema1208 commented Jan 4, 2024

@bhargavaparoksham good news: I was able to successfully payout in mkUSD! Successful tx: https://etherscan.io/tx/0x736eb34a5dd3c2262e38f00549d0e3d4a6d1b4cfccec36b238a680197d46fbfd

Small UX issue: the formatting of the "mkUSD" label is a bit off - could we make this more responsive?

Screen Shot 2024-01-04 at 3 08 47 PM

Round: https://manager-git-manager-2762-grants-stack.vercel.app/#/round/0x51dde82c29613f6b539289106a9c8d27822be445/application/0x51dde82c29613f6b539289106a9c8d27822be445-0

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

gitstream-cm bot commented Jan 8, 2024

🥷 Code experts: vacekj

bhargavaparoksham, vacekj have most 👩‍💻 activity in the files.
bhargavaparoksham, vacekj have most 🧠 knowledge in the files.

See details

packages/common/src/index.ts

Activity based on git-commit:

bhargavaparoksham vacekj
JAN
DEC 8 additions & 0 deletions
NOV 2 additions & 2 deletions 0 additions & 1 deletions
OCT 23 additions & 17 deletions
SEP 20 additions & 4 deletions
AUG 16 additions & 9 deletions

Knowledge based on git-blame:
vacekj: 55%
bhargavaparoksham: 18%

packages/round-manager/src/features/api/payoutTokens.ts

Activity based on git-commit:

bhargavaparoksham vacekj
JAN 0 additions & 8 deletions
DEC 98 additions & 0 deletions 299 additions & 0 deletions
NOV
OCT
SEP
AUG

Knowledge based on git-blame:
vacekj: 76%
bhargavaparoksham: 23%

packages/round-manager/src/features/round/ApplicationDirectPayout.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
JAN
DEC 1 additions & 1 deletions
NOV
OCT 473 additions & 6 deletions
SEP
AUG

Knowledge based on git-blame:
bhargavaparoksham: 98%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 8, 2024

This PR is 91.11111111111111% new code.

@bhargavaparoksham bhargavaparoksham merged commit 9988555 into main Jan 8, 2024
19 checks passed
@bhargavaparoksham bhargavaparoksham deleted the manager-2762 branch January 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mkUSD as payout token for direct grants
4 participants