Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy correct url when clicking "share profile" #2750

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: copy correct url when clicking "share profile" #2750

merged 1 commit into from
Jan 3, 2024

Conversation

bard
Copy link
Contributor

@bard bard commented Dec 19, 2023 •
edited
Loading

Fixes: #2705

Description

  • fix copied text
  • add test

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am
builder-staging ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am
explorer ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am
explorer-staging ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am
manager ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am
manager-staging ✅ Ready (Inspect) Visit Preview Dec 19, 2023 0:33am

@bard bard marked this pull request as ready for review December 19, 2023 12:54
@bard bard requested review from a team as code owners December 19, 2023 12:54
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Dec 19, 2023

This PR is 52.55813953488372% new code.

@bard bard self-assigned this Dec 19, 2023
melissa-neira
melissa-neira approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

meglister
meglister approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@meglister meglister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melissa-neira melissa-neira merged commit ddebd6b into main Jan 3, 2024
20 checks passed
@melissa-neira melissa-neira deleted the fix-share-address-copied-profile branch January 3, 2024 19:26
xinbianjiang20 pushed a commit to xinbianjiang20/grants-stack that referenced this pull request Jan 6, 2024
@bard @xinbianjiang20
fix: copy correct url when clicking "share profile" (gitcoinco#2750)
c89f65c
xinbianjiang20 pushed a commit to xinbianjiang20/grants-stack that referenced this pull request Jan 6, 2024
@bard @xinbianjiang20
fix: copy correct url when clicking "share profile" (gitcoinco#2750)
f18c0ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vacekj vacekj vacekj approved these changes

@meglister meglister meglister approved these changes

@melissa-neira melissa-neira melissa-neira approved these changes

Assignees

@bard bard

Labels
5 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Share Profile" button on contributor page copies wrong URL
4 participants
@bard @vacekj @meglister @melissa-neira