Skip to content

contract improvements suggestion #91

Closed Answered by thelostone-mc
thelostone-mc asked this question in Q&A
Discussion options

You must be logged in to vote

Set ROLE value in the initialize function (instead of hardcoding as constants) - @gravityrocks

We aren't implementing this ATM simply cause

  • contracts are now upgradable
  • cannot think of a reason why we would want to update the ROLE value (unless we are adding new roles -> which would inturn require a contract upgrade)
  • additionally having it as a constant ensure it's there in the bytecode -> less gas costs -> aka cheaper by keeping it as it is

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by thelostone-mc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
1 participant