-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: protect read file from path traversal #4943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject's root path
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mtsgrd
reviewed
Sep 18, 2024
ndom91
force-pushed
the
fix-protect-read-file-from-path-traversal
branch
from
September 18, 2024 12:41
366a8ac
to
a4c89ba
Compare
@mtsgrd some small rust question:
|
ndom91
force-pushed
the
fix-protect-read-file-from-path-traversal
branch
from
September 18, 2024 12:43
a4c89ba
to
25dcaac
Compare
ndom91
force-pushed
the
fix-protect-read-file-from-path-traversal
branch
from
September 18, 2024 12:47
9339384
to
a344d6a
Compare
krlvi
reviewed
Sep 18, 2024
Features are predefined in the crate and they usually only provide features if it grates off other dependencies, not just code. When I see the example above, it reminds me of typescript imports :). |
ndom91
force-pushed
the
fix-protect-read-file-from-path-traversal
branch
from
September 18, 2024 14:29
e921c44
to
e0c6118
Compare
krlvi
approved these changes
Sep 21, 2024
ndom91
force-pushed
the
fix-protect-read-file-from-path-traversal
branch
from
September 22, 2024 17:07
6f8eb44
to
a9fabb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
get_pr_template_contents
fn can't read anything outside of the project's root directory🧢 Changes