UI: Upgrade to Storybook 8.3.0-beta.0, add Vitest to UI package
#4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JReinhold is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
JReinhold
commented
Aug 30, 2024
| @@ -8,7 +8,8 @@ const preview: Preview = { | |||
| backgrounds: { disable: true }, | |||
| controls: { | |||
| matchers: { | |||
| color: /(background|color)$/i, | |||
| // matches "background" and "color" but not "solidBackground" as that is a boolean arg | |||
| color: /(?<!solid)(background|color)$/i, | |||
There was a problem hiding this comment.
this silents a console warning that the controls addon was logging in a story that uses solidBackground. The console warning was more noticeable in the Vitest tests because it would show up in the output.
JReinhold
commented
Aug 30, 2024
| "storybook-dark-mode": "^4.0.2", | ||
| "svelte": "catalog:svelte", | ||
| "svelte-check": "catalog:svelte", | ||
| "vite": "catalog:" | ||
| "util": "^0.12.5", |
There was a problem hiding this comment.
util here is a temporary workaround for storybookjs/storybook#29008. Can be removed again when that fix has been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Storybook maintainer here. 👋
As part of our upcoming 8.3.0 release of Storybook, we're QAing it using various open source projects like this one. I figured that since I did this upgrade I might as well open a PR with it so you can benefit from it, or not.
Feel free to immediately close this PR if it's not interesting to you.
🧢 Changes
8.3.0-beta.0Read more about the experiment here: https://web-git-8-3-pre-release-storybookjs.vercel.app/docs/writing-tests/test-runner-with-vitest
It worked flawlessly in your setup:
I added appropriate scripts which turbo picks up, but I did not add it to CI.
📌 Todos