Update to Go 1.21 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Go version 1.21, the "go" command may, under certain circumstances, fetch a different version of the Go toolchain than is provided locally, as described in git-lfs/git-lfs#5477, PR git-lfs/build-dockers#58, and the Go documentation: https://go.dev/doc/toolchain In general, we do not expect this to occur, as we specify an older Go version in our go.mod file and so the locally-installed Go toolchain should be newer than that version and therefore sufficient. However, to be cautious and ensure we only try to run with the Go version we have specified, we add the GOTOOLCHAIN=local environment variable to all our GitHub Actions workflow jobs. Defining this variable will guarantee that Go will stop with an error rather than proceed to download and run another version of itself.
As our official policy is to support the latest version of Go, we upgrade our CI workflow to version 1.21, which was recently released. We also drop support for versions older than 1.20 as they are not supported by upstream Go.
bk2204
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our official policy for the Git LFS project is to support the latest version of Go, we upgrade our CI workflow to version 1.21, which was recently released.
We also drop CI job runs (and therefore official support) for versions older than 1.20, as they are not supported by upstream Go.
Note that several older required CI jobs will not run for this PR, and the newer jobs should be marked as required after this PR is merged.